Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to automatic and multilanguage package #43

Closed
wants to merge 4 commits into from
Closed

Updating to automatic and multilanguage package #43

wants to merge 4 commits into from

Conversation

adgellida
Copy link

See the changes and apport changes if it's necessary

@ferventcoder
Copy link
Owner

Thanks, I will evaluate this and get back to you on it.

@ferventcoder
Copy link
Owner

Still holding on this guy until I can test it properly.

$packageName = 'adobereader'
$installerType = 'EXE'
$silentArgs = '/sAll /msi /norestart /quiet ALLUSERS=1 EULA_ACCEPT=YES'
#$url = 'http://ardownload.adobe.com/pub/adobe/reader/win/{mainversion}.x/{version}/en_US/AdbeRdr{version:replace:.:}_en_US.exe'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is incorrect. {version:replace:.:} is a function of ketarin, not of powershell.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, adobereader isn't multi yet? u can do it manual but multi if not?

2014-02-09 21:33 GMT+01:00 Rob Reynolds notifications@github.com:

In adobereader/tools/chocolateyInstall.ps1:

@@ -1,8 +1,42 @@
-$silentArgs = '/sPB /msi /norestart /quiet ALLUSERS=1 EULA_ACCEPT=YES'
-$downloadUrl = '{{DownloadUrl}}'
+$packageName = 'adobereader'
+$installerType = 'EXE'
+$silentArgs = '/sAll /msi /norestart /quiet ALLUSERS=1 EULA_ACCEPT=YES'
+#$url = 'http://ardownload.adobe.com/pub/adobe/reader/win/{mainversion}.x/{version}/en_US/AdbeRdr{version:replace:.:}_en_US.exe'

This line is incorrect. version:replace:.:} is a function of ketarin, not
of powershell.

Reply to this email directly or view it on GitHubhttps://github.com//pull/43/files#r9570693
.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you are attempting to call a KETARIN function in PowerShell which does not know {mainversion} {version} or {version.replace:.:}. This looks to be a copy/paste error. (Oh wait) you have this commented.

Nevermind. Ignore this. :)

Can you check this?
@ferventcoder
Copy link
Owner

I'm pulling in the gist of this into https://github.com/ferventcoder/chocolatey-packages

@adgellida
Copy link
Author

Hurray! But now I'm on the Open Source wave with your Sumatra package. For
all the other people it will be find, so delete:

<goog_1658066316>
https://chocolatey.org/packages/adobereader-de
https://chocolatey.org/packages/adobereader-jp
https://chocolatey.org/packages/simnetsa-adobereader-fr
https://chocolatey.org/packages/BR.AdobeReaderFR

Ok?

2014-09-24 15:11 GMT+02:00 Rob Reynolds notifications@github.com:

I'm pulling in the gist of this into
https://github.com/ferventcoder/chocolatey-packages


Reply to this email directly or view it on GitHub
#43 (comment)
.

@adgellida adgellida closed this Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants